-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error for implicit catch statement #8241
Conversation
Thanks for your pull request, @JinShil! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8241" |
src/dmd/statementsem.d
Outdated
@@ -4105,8 +4105,9 @@ void catchSemantic(Catch c, Scope* sc) | |||
|
|||
if (!c.type) | |||
{ | |||
deprecation(c.loc, "`catch` statement without an exception " ~ | |||
error(c.loc, "`catch` statement without an exception " ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errorSupplemental might be a good idea here for the second line.
Seems like two D projects need upgrades first :/ |
I'm not sure how Jenkins selects the branch to test, but the error messages don't seem to correspond to the code in the repositories' master branch. Maybe the repositories just need an updated tag. |
Yes, Jenkins checks out the latest git tag. |
Regarding the Jenkins failure - the Ocean failure is unrelated. |
Interestingly this triggers an ICE when building dlang.org:
|
I've seen that before in DAutoTest. I simply initiated a new build and it went away. The same issue was also noticed in DAutoTest for dlang/druntime#2176. It appears @TurkeyMan solved that also by pushing again and initiating a new build. I don't know what the core problem is, but it's not related to this PR. cc @CyberShadow Edit: You can currently see this same error manifesting itself at #8234. See the DAutoTest output |
This is still waiting on msgpack-d, so I'm removing the auto-merge label to de-prioritize it in the CI. |
How long are we supposed to wait on jenkins projects to update themselves? It's been a fair amount of time since this PR was open not to mention the deprecation period. I suggest that we move on with this. |
Three days. If a PR was needed to fix the project and hasn't been merged yet before we remove the project due to inactivity. |
FYI, msgpack-d is used by DCD. |
Then we should better try to move it to dlang-community :O |
See https://dlang.org/deprecate.html#Implicit%20catch%20statement
This PR moves a deprecation forward, further narrowing the gap between specification and implementation.
Update to deprecated features table: dlang/dlang.org#2365