for non-ptr params, return-scope goes away #9374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9374" |
thewilsonator
previously requested changes
Feb 19, 2019
thewilsonator
added
the
Needs Spec PR
WalterBright
force-pushed
the
return-scope
branch
3 times, most recently
from
3b2ee66
to
a0ea3d9
Compare
WalterBright
force-pushed
the
return-scope
branch
from
a0ea3d9
to
6828aa2
Compare
|
Spec PR: dlang/dlang.org#2584 |
WalterBright
removed
the
Needs Spec PR
WalterBright
dismissed
thewilsonator’s stale review
spec PR added, test case too.
WalterBright
added
the
Blocking Other Work
|
Blocking #9220 |
thewilsonator
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
ref return scope pmeansrefandreturn scope. But forref return scope iit meansref return i. This changes the latter to beref i. The reason is generic code, where the type of i or p is not known in advance. Makes for consistent behavior with generic code.