Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn deprecation into error for invalid integer literals #9930

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented May 31, 2019

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9930"

@kubo39
Copy link
Contributor Author

kubo39 commented May 31, 2019

Ahh, test/unit/lexer/diagnostic_reporter.d uses this for test. I'll investigate another deprecated feature for it.

@jacob-carlborg
Copy link
Contributor

Ahh, test/unit/lexer/diagnostic_reporter.d uses this for test. I'll investigate another deprecated feature for it.

There doesn't seem to be any other deprecated feature in the lexer. You can remove that test.

@kubo39 kubo39 force-pushed the error-invalid_integer_literal branch from deee73f to 358bb62 Compare May 31, 2019 18:46
@kubo39 kubo39 force-pushed the error-invalid_integer_literal branch from 358bb62 to c4ee28e Compare May 31, 2019 18:57
@dlang-bot dlang-bot merged commit 163d509 into dlang:master Jun 1, 2019
@kubo39 kubo39 deleted the error-invalid_integer_literal branch June 1, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants