Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

WalterBright
Copy link
Member

No description provided.

@WalterBright WalterBright force-pushed the add-dwarfeh-d branch 3 times, most recently from 09381f2 to d4dbc6e Compare December 28, 2015 12:31
andralex added a commit that referenced this pull request Dec 28, 2015
@andralex andralex merged commit 4ed3b72 into dlang:master Dec 28, 2015
@WalterBright WalterBright deleted the add-dwarfeh-d branch December 28, 2015 18:45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break when moving stacks with an in-flight exception to a different thread (where it would then try to free the static buffer from a different thread)? (the alpha for the current LDC release has a similar problem too, although it's apparently very unlikely to occur for us)

@MartinNowak
Copy link
Member

Thanks, moved the card to done.
https://trello.com/c/ndzxBBqP/141-move-core-sys-unwind-to-rt-unwind

@dnadlinger
Copy link
Contributor

@MartinNowak: It shouldn't have been. The implementation still uses the core.sys.unwind "header".

@MartinNowak
Copy link
Member

@MartinNowak: It shouldn't have been. The implementation still uses the core.sys.unwind "header".

Wait, this doesn't delete the public interface :o, why was it merged then?

@MartinNowak
Copy link
Member

I made a checklist, just in case.
https://trello.com/c/ndzxBBqP/141-move-core-sys-unwind-to-rt-unwind

@dnadlinger
Copy link
Contributor

@MartinNowak: There is a misunderstanding. rt.dwarfeh is the client code that uses the libunwind interface. I've updated that card accordingly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants