Implement single-file packages. Fixes #103. #851
Conversation
|
Inferring the package name requires some additional changes. |
| #!/usr/bin/env dub | ||
| /+ SDL | ||
| name "hello_world" | ||
| +/ |
There was a problem hiding this comment.
Is it possible to have a tested example with dependencies?
There was a problem hiding this comment.
Good point. While normal dependencies work fine, while extending the test case, I noticed that path based dependencies are broken. Fixing this cleanly requires some more thought.
|
Okay, should be ready now. I propose to defer inferring the package name, because that requires some package parser API changes that may or may not be worth it. |
|
Overall LGTM. BTW is dub.json supported as a comment? |
|
The pretty informative comment on |
|
Thanks for looking through it! I'll add a dub.json test and rebase + pull. |
| string file_content = readText(path.toNativeString()); | ||
| auto idx = file_content.indexOf("/+"); | ||
| enforce(idx >= 0, "Missing /+ ... +/ recipe comment."); | ||
| file_content = file_content[idx+2 .. $].strip(); |
There was a problem hiding this comment.
I think calling strip here is unnecessary, as the call below should cover its purpose.
There was a problem hiding this comment.
Indeed, that was left-over from an earlier code version.
s-ludwig
force-pushed
the
issue103_single_file_packages
branch
from
144299c
to
8131dc5
Compare
Can be invoked by either running with the --single switch, or by omitting the command and instead specifying a file with a .d extension.
s-ludwig
force-pushed
the
issue103_single_file_packages
branch
from
8131dc5
to
810257e
Compare
|
Thanks for the changes (especially for removing the |
|
Travis is green again. Merging. |
See #103.