Fix Issue 19312 - Reduce template bloat in std.math by using const arguments #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @n8sh! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6731" |
n8sh
force-pushed
the
issue-19312
branch
5 times, most recently
from
a0258c8
to
cb281d7
Compare
n8sh
commented
Oct 18, 2018
| @@ -6302,34 +6303,34 @@ version (D_HardFloat) @safe unittest // rounding | |||
| * Returns: | |||
| * `true` if $(D_PARAM x) is Nan. | |||
| */ | |||
| bool isNaN(X)(X x) @nogc @trusted pure nothrow | |||
| bool isNaN(X)(const X x) @nogc @trusted pure nothrow | |||
There was a problem hiding this comment.
const here causes an error in CTFE for isNaN(real.nan). Removing the const allows it to work fine. Bizarre.
There was a problem hiding this comment.
My guess is that isNaN (along with other functions) is evaluated as a built-in at compile-time and such built-ins are matched by their mangled name in dmd.
There was a problem hiding this comment.
Yep. Although some of those builtins are outdated and can (will!) removed at some point, because the real builtins are in core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labeling variably-typed arguments of template functions as const causes the same type to be inferred when the argument is const, non-const, and immutable.