Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Remove etc odbc deprecated module #8748

Closed
wants to merge 1 commit into from

Conversation

Dany12LU
Copy link

@Dany12LU Dany12LU commented May 6, 2023

Experimental removal to see what breaks

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Dany12LU! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8748"

@dkorpel
Copy link
Contributor

dkorpel commented May 10, 2023

Looks like nothing on buildkite breaks (the Azure OMF failure is unrelated), but the deprecation comment says to wait until version 2.106

@LightBender
Copy link
Contributor

Please do not merge this. This PR is based on an incorrect premise.

The etc.d.odbc.* modules should not be deprecated, and conversely, there should not have ever been core.sys.windows.sql* modules, those should be deprecated instead.

ODBC is not a Windows specific system. Both MacOS and Linux fully support ODBC and all major DB vendors support ODBC on all three platforms. MySql/PGSQL/MSSQL/Oracle, all maintain supported ODBC drivers for the above platforms, even cloud DB's such as Amazon Redshift maintain supported ODBC drivers for all three systems. And in some cases, as with MSSQL, ODBC is the only way to access the database on Linux. I currently have a non-public project that uses ODBC on Linux to access MSSQL.

Additionally, database drivers of any kind do not belong in DRT as they are not germane to the runtime of every D app.

@LightBender
Copy link
Contributor

Resurrecting this. I have posted two new PRs. The first PR deprecates ODBC in DRT. The second puts ODBC back into Phobos and updates it to support non-Windows systems.
DRT: dlang/dmd#15560
Phobos: #8804

@LightBender
Copy link
Contributor

@Dany12LU The above two referenced PRs have been merged. This PR has been superseded and can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants