Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo ODBC deprecation and enable usage on non-Windows systems. #8804

Merged
merged 13 commits into from
Aug 31, 2023

Conversation

LightBender
Copy link
Contributor

@LightBender LightBender commented Aug 29, 2023

This PR moves ODBC back to Phobos where it belongs. It also adds the appropriate type aliases for non-Windows systems removing the Windows only limitation.

Paris with: dlang/dmd#15560

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @LightBender! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8804"

etc/c/odbc/sql.d Outdated Show resolved Hide resolved
etc/c/odbc/sqlucode.d Outdated Show resolved Hide resolved
etc/c/odbc/sqlext.d Outdated Show resolved Hide resolved
@thewilsonator thewilsonator merged commit 1be6d5d into dlang:master Aug 31, 2023
7 of 10 checks passed
@LightBender LightBender deleted the odbc-dep branch August 31, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants