Skip to content

Conversation

willi-mueller
Copy link
Collaborator

Tell us what you do here

  • improving, documenting, or customizing an existing source (please link an issue or describe below)

Relevant issue

issue #313

More PR info

Before:

See https://setuptools.pypa.io/en/latest/pkg_resources.html
    import pkg_resources

tests/rest_api/conftest.py:75
  dlt-verified-sources/tests/rest_api/conftest.py:75: DeprecationWarning: invalid escape sequence '\?'
    @router.get("/posts(\?page=\d+)?$")

tests/rest_api/conftest.py:79
  dlt-verified-sources/tests/rest_api/conftest.py:79: DeprecationWarning: invalid escape sequence '\d'
    @router.get("/posts/(\d+)/comments")

tests/rest_api/conftest.py:84
  dlt-verified-sources/tests/rest_api/conftest.py:84: DeprecationWarning: invalid escape sequence '\d'
    @router.get("/posts/\d+$")

tests/rest_api/conftest.py:89
  dlt-verified-sources/tests/rest_api/conftest.py:89: DeprecationWarning: invalid escape sequence '\d'
    @router.get("/posts/\d+/some_details_404")

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

After

Screenshot 2024-02-29 at 15 15 28

@willi-mueller willi-mueller force-pushed the fixes-deprecation-warning branch from a164a52 to 44a5262 Compare March 1, 2024 11:26
@willi-mueller willi-mueller changed the title fixes deprecation warning [REST source] fixes deprecation warning Mar 1, 2024
@burnash burnash merged commit 71b4682 into dlt-hub:enh/api_helper Mar 1, 2024
@burnash
Copy link
Collaborator

burnash commented Mar 1, 2024

Thanks, @willi-mueller!

burnash added a commit that referenced this pull request Mar 22, 2024
* REST API: support all authentication methods (#354)
* Generic API client: include parent fields in child resource (#355)
* Rest API: Ends pagination if next page path is not in response.json() (#361)
* Allow specification of SinglePagePaginator and refactors redundancy (#364)
* [REST Source] renames default_paginator argument to paginator (#367)
* [REST Source] completes renaming of default_paginator to paginator (#370)
* [REST source] test case for dependent resource (#371)
* [REST API source] adds function to check connection (#357)
* [REST Source] allow skipping http errors (#365)
* added the possibility to pass HTTPBasicAuth objects (#377)
* [REST] Detailed error handler logging (#383)
* [REST source] header_links can extract from responses without a records_path (#382)
* [REST source] fixes deprecation warning (#380)
* [REST CLIENT] alt response extractor (#396)
* Makes openapi friendly auth (#397)
* [REST CLIENT] yields data pages with requests context (#399)

---------

Co-authored-by: Anton Burnashev <anton.burnashev@gmail.com>
Co-authored-by: Willi Müller <willi.mueller@posteo.de>
Co-authored-by: mucio <mucio@mucio.net>
Co-authored-by: rudolfix <rudolfix@rudolfix.org>
Co-authored-by: Steinthor Palsson <steini90@gmail.com>
@willi-mueller willi-mueller deleted the fixes-deprecation-warning branch June 27, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants