-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notion): pages resource returns only meta info #460
base: master
Are you sure you want to change the base?
Conversation
@adrianbr, the thing is - I don't have straight access to the Notion account, so I can't always say if it's content or just metadata - some fields look like what's needed to me. With new changes, it returns blocks, let's see:
|
assert cur.fetchone()[1] in requested_pages | ||
row = cur.fetchone() | ||
assert row[0] == "block" | ||
assert row[3] == page_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the resource type and id of the parent page (as it was requested)
@adrianbr are you going to review it? if not please assign someone so we get exactly what you wanted :) |
This PR is a bit stuck |
Closes #413