-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example][Refactor] Regolden graphsage example for future guide #4186
[Example][Refactor] Regolden graphsage example for future guide #4186
Conversation
To trigger regression tests:
|
Will |
Done a first pass, some minor comments |
@mufeili Addressed your comments expect the ones about inference. I feel that part may be changed quite significantly in the future so we may not want to focus on it too much. Plus, many full graph examples do not need it. |
@mufeili @jermainewang |
LGTM. |
I'll just merge it. Don't want to wait for CI, which is currently quite overloaded. |
Description
Simplify from #4159
Focus on single-GPU, mini-batch node classification task (graphsage/node_classification.py) to ease the iterating process.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes
Tests
python3 node_classification.py --gpu 0