[Example][Refactor] Refactor GAT example #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
mufeili
reviewed
Jul 17, 2022
| ```bash | ||
| python3 train_ppi.py --gpu=0 | ||
| python3 train.py --dataset cora |
There was a problem hiding this comment.
Why did you drop the support of PPI?
There was a problem hiding this comment.
I was thinking of simplicity.
Added PPI support back in case you think it is necessary (reported 5-rerun results compared to older version in above PR description).
There was a problem hiding this comment.
Also as a reminder here, I have removed "early stopping" function in both train.py and train_ppi.py for simplicity. Please let me know if you think if it is necessary and I will add it back.
There was a problem hiding this comment.
@jermainewang @yzh119 What do you think? Early stopping was added because some users complained about the accuracy.
mufeili
reviewed
Jul 17, 2022
chang-l
force-pushed
the
refactor-gat-example
branch
from
e4a9467
to
36b467d
Compare
mufeili
reviewed
Jul 20, 2022
mufeili
reviewed
Jul 20, 2022
mufeili
reviewed
Jul 20, 2022
mufeili
reviewed
Jul 20, 2022
mufeili
reviewed
Jul 20, 2022
mufeili
reviewed
Jul 20, 2022
mufeili
reviewed
Jul 20, 2022
mufeili
reviewed
Jul 20, 2022
mufeili
reviewed
Jul 20, 2022
chang-l
force-pushed
the
refactor-gat-example
branch
from
e958d8a
to
93dd2a7
Compare
chang-l
commented
Jul 20, 2022
mufeili
approved these changes
Jul 22, 2022
BarclayII
pushed a commit
to BarclayII/dgl
that referenced
this pull request
Aug 10, 2022
* Refactor gat example * Add ppi support * Minor update * Update * Update * Change valid_xxx to val_xxx * Readme Update * Update Co-authored-by: Mufei Li <mufeili1996@gmail.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Referring to: #4186, this PR is for refactoring GAT example. Only single GPU is implemented.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes
--dataset, while using their default valuesResults