Added DMLC_DECLARE_TRAITS(is_pod, int8_t, true); #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compilation on g++-4.8 and clang++-3.5.
|
Please also remove the line for int8_t since I guess char will be more often used, and seems MSVC indeed use char for int8_t |
|
This is exactly what I was worried about. Simply adding "char" is a not a cross-platform solution, as would be simply removing int8_t. We should make this compiler dependent, or have a good way to detect (at compilation time) of char == int8_t. |
|
Alright, I think it is fine anyway, since traits is only needed for non c++11 compile mode, and MSVC is by default c++11 and this section will not be enabled. I will merge it in for now. Thanks! |
|
We can remove int8_t for now since it is not usually used in most cases. In common case(c++11 enabled) the library will always compile correctly |
tqchen
added a commit
that referenced
this pull request
Jul 17, 2015
Added DMLC_DECLARE_TRAITS(is_pod, int8_t, true);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation on g++-4.8 and clang++-3.5.