-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove Camlimages and migrate to raw C io #47
Conversation
@dmtrKovalenko So xpm support would need a ton of work (if at all possible) to be statically linked inside odiff. I did nearly finish My question would be: |
I took an xpm because there was no-effort support by camlimages. I think we can drop it for free.
|
Thats great! ...leaving this here for future reference 😄 |
🎉🎉🎉 Its working on Windows!!! |
Thank you 😄 |
I added tests for every IO type we currently have. |
We can remove them |
I didn't notice, that the tests were failing with "Out of memory" on windows ci. 😄 Weirdly enough, switching from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Sorry I was so overwhelmed with work and finally get some time to test this and thank you for this awesome stuff.
This PR is the work for removing camlimages and replacing it with linked in libraries and handwritten bindings.
Once this is done, we should not require any global library to run odiff.
One concern is, that the size of the binary and npm package will get too big, so I will keep track of the sizes at each step:
XPM??? Byte