Update to junit 5, remove powermock #1520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmulloy2
requested changes
Feb 24, 2022
| BukkitInitialization.initializeItemMeta(); | ||
| BukkitInitialization.initializePackage(); | ||
| BukkitInitialization.initializeAll(); | ||
| BukkitInitialization.initializeAll(); |
There was a problem hiding this comment.
Probably just a result of the find and replace, but this doesn't need to be called twice
| } | ||
|
|
||
| // @Test | ||
| @Test |
There was a problem hiding this comment.
I typically don't run this test by default since it has to make web requests, but sometimes uncomment this to more easily test it if it breaks for some reason
|
Manually merged in 55f7b67 |
|
Thanks for resolving the things for me 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests removes pockermock (which is a pain because of incompatibility with java 17 and junit 5) and junit4. The replacements for them are junit5 and mockito, using the inline mock maker to also allow mocking of final classes.
The code was reformatted by IJ which moved quite a bit of stuff around. I would love to get some feedback regarding reformatting the main package, especially about moving away from tabs to 2 spaces (which is imho much readable).
(This change compiles correctly and all tests are passing, see #1510 why it's not compiling with GH actions 😄 )