Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yoyo in EFF wordlist #14

Closed
jpnp opened this issue Jun 11, 2019 · 2 comments
Closed

yoyo in EFF wordlist #14

jpnp opened this issue Jun 11, 2019 · 2 comments
Assignees
Labels

Comments

@jpnp
Copy link

jpnp commented Jun 11, 2019

I like the use of the EFF wordlist but it contains both yoyo (66631) and yo-yo (66622). Depending on only hyphenation to seperate entries seems like a bug (no other hyphenated entry in the EFF list is also present in non-hyphenated form).

Perhaps one of the yoyos can be substituted in your implementation?

@dmuth dmuth self-assigned this Jun 12, 2019
@dmuth dmuth added the bug label Jun 12, 2019
@dmuth
Copy link
Owner

dmuth commented Jun 12, 2019

Wow, nice find! I reached out to the author of the EFF wordlist and let them know.

Unless they suggest something differently, I'll probably just replace the hyphenated version with another word in a day or two.

Best,

-- Doug

@dmuth
Copy link
Owner

dmuth commented Jun 16, 2019

This has been fixed and uploaded, but I see that it hasn't propagated to https://diceware.dmuth.org/wordlist/wordlist-5-dice-eff.js yet. Since the site is served through AWS CloudFront, it may be some time for those changes to show, but the necessary work has been done.

Thanks again for reporting this!

-- Doug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants