docs(Tabs): improve property docs #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joakbjerk
approved these changes
Jun 5, 2024
|
Actually, looking at this closer, we should use the same approach as done with ProgressIndicator, where a value as object gets a new table. Added a commit for this. 
|
tujoworker
force-pushed
the
docs/improve-prop-docs-of-tabs
branch
from
69ad7af
to
5e6e344
Compare
Great, seems like a way better way of solving it then what I suggested 👍 |
tujoworker
pushed a commit
that referenced
this pull request
Jun 14, 2024
## [10.36.0](v10.35.0...v10.36.0) (2024-06-14) ### ✨ Features * **Anchor:** add helper classes as props ([#3701](#3701)) ([62b23e8](62b23e8)) * **forms:** add `activeWhen` prop to Wizard.Step ([#3705](#3705)) ([edd6214](edd6214)) * **Icon:** rewrite to TypeScript and hooks ([#3703](#3703)) ([70b1f8b](70b1f8b)), closes [#3699](#3699) * **Table:** refactoring of types, documentation, and accordion file structure ([#3683](#3683)) ([6045e42](6045e42)) ### 🐛 Bug Fixes * **Autocomplete:** make `input_value` react to prop change ([#3706](#3706)) ([641e5e7](641e5e7)) * **Autocomplete:** make inputValue update on data prop changes ([#3581](#3581)) ([83b05cf](83b05cf)) * **forms:** ensure useReactRouter to handle initial data given by url ([#3708](#3708)) ([a16f1f7](a16f1f7)), closes [#3702](#3702) * **StepIndicator:** avoid re-assigning functions that can cause titles to be not in sync ([#3697](#3697)) ([d8d740c](d8d740c)), closes [#3685](#3685) ### 📝 Documentation * **forms:** add translations table ([#3693](#3693)) ([84605b7](84605b7)) * **Tabs:** fix the title of Tabs breakout example ([#3696](#3696)) ([7747e06](7747e06)) * **Tabs:** improve property docs ([#3665](#3665)) ([7849cba](7849cba)) * update grid layout example without responsive sidebar ([#3709](#3709)) ([f4363c2](f4363c2))
|
🎉 This PR is included in version 10.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel that the properties docs of tabs is not very readable because of how the
dataproperty'stypeis formatted.This is just a suggestion, but instead of changing the values of the type property(as I've done in the PR here) we should probably change the styling or so, to accomplish the same. Perhaps the
PropertiesTableis the correct place to change? 🤔From:
To: