Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Conversation

rumpl
Copy link
Contributor

@rumpl rumpl commented May 18, 2020

First check from #68

fmt.Fprintf(w, format, c.Name, c.Metadata.Description, c.Metadata.Type)
contextName := c.Name
if c.Name == currentContext {
contextName += " *"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justincormack what UX would you like for this? A star before the name might be nice. Something like:

$ docker context ls
  NAME    DESCRIPTION TYPE
* example             example
  aci                 aci
  moby                moby

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, we could have colors?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or at first, should we keep the "classic" UX : star after the name ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this one, we can have the conversation on slack

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, already done :)

Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumpl rumpl force-pushed the feat-context-list branch from 0fd1d00 to 3891c8c Compare May 18, 2020 14:42
@rumpl rumpl merged commit 04e6023 into master May 18, 2020
@rumpl rumpl deleted the feat-context-list branch May 18, 2020 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants