This repository was archived by the owner on Nov 27, 2023. It is now read-only.
detect stopped containers as "Created" #1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
restart_logs
branch
from
66fcc31 to
d56745c
Compare
gtardif
reviewed
Feb 12, 2021
| @@ -114,7 +114,7 @@ func (s *composeService) getContainerStreams(ctx context.Context, container moby | |||
| Stdin: true, | |||
| Stdout: true, | |||
| Stderr: true, | |||
| Logs: true, | |||
| Logs: false, | |||
There was a problem hiding this comment.
Looking back at the history of this (3714ab7), this was set to true because we were loosing some logs in run (with a race probably). Is this not needed anymore ?
There was a problem hiding this comment.
yes indeed.
according to API docs Logs: Replay previous logs from the container is the main reason we get logs from previous runs as described in #1289
this option is usefull to attach to a container that's already running, but here we attach before we call start, so not needed
gtardif
approved these changes
Feb 12, 2021
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
restart_logs
branch
from
eb7d6a8 to
4462f12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
consider "exited" container from a previous run as "Created" so we just need to invoke start
Related issue
#1289
(not mandatory) A picture of a cute animal, if possible in relation with what you did