Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Conversation

ulyssessouza
Copy link
Contributor

@ulyssessouza ulyssessouza commented Jul 7, 2020

What I did
In the case where the command has arguments
it fails because ACI implementation does not
support commands with arguments

Non interactive:

$ make && bin/docker --context aci exec <container> pwd

Interactive:

$ make && bin/docker --context aci exec -t <container> /bin/sh

Related issue
Resolves: #130

(not mandatory) A picture of a cute animal, if possible in relation with what you did
interactive-goat

In the case where the command has arguments
it fails because ACI implementation does not
support commands with arguments

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
@ulyssessouza ulyssessouza requested a review from gtardif July 7, 2020 07:38
@ulyssessouza ulyssessouza marked this pull request as ready for review July 7, 2020 09:36
@ulyssessouza ulyssessouza self-assigned this Jul 7, 2020
@gtardif gtardif merged commit 16acc36 into master Jul 7, 2020
@gtardif gtardif deleted the fix-non-interactive branch July 7, 2020 10:41
@gtardif
Copy link
Contributor

gtardif commented Jul 7, 2020

Merged.
Another improvement we should do : do not start any interactive shell if the user does not specify -it (like docker exec mycontainer /bin/sh : this just returns with no output on a local container

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACI : allow non-interactive exec with specified command
2 participants