This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Prefer external.name over x-aws-securitygroup #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add support for
networks.external
for users to configure an existing security-groupThis reduces the (already too large) set of custom extensions we introduced for AWS support
@nebuk89 shall we drop support for x-aws-securitygroup that is not required then ?
/test-ecs
(not mandatory) A picture of a cute animal, if possible in relation with what you did
