Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Sep 15, 2020

What I did
Add support for networks.external for users to configure an existing security-group
This reduces the (already too large) set of custom extensions we introduced for AWS support

@nebuk89 shall we drop support for x-aws-securitygroup that is not required then ?

/test-ecs

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

networks:
  back_tier:
    external: true
    name: "sg-1234acbd"    

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@github-actions github-actions bot added the ecs label Sep 15, 2020
@ndeloof ndeloof requested a review from aiordache September 15, 2020 16:30
@nebuk89
Copy link

nebuk89 commented Sep 16, 2020

Yep sounds like a good plan to me

@ndeloof
Copy link
Collaborator Author

ndeloof commented Sep 16, 2020

update to documentation => #623

Copy link
Contributor

@gtardif gtardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM technically.
Do we want to keep supporting the extension with a warning for some time as the code does here, or remove this extension completely & force users to use external ?

@ndeloof ndeloof merged commit 387370d into main Sep 17, 2020
@ndeloof ndeloof deleted the external branch September 17, 2020 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants