Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Conversation

wfarner
Copy link
Contributor

@wfarner wfarner commented Dec 1, 2016

We were already partially doing this for some plugins, but these ones were split between pkg/plugin and pkg/example. i think it makes everyone's life easier if each plugin's code is centralized.

Signed-off-by: Bill Farner bill@docker.com

Signed-off-by: Bill Farner <bill@docker.com>
Signed-off-by: Bill Farner <bill@docker.com>
@codecov-io
Copy link

codecov-io commented Dec 1, 2016

Current coverage is 67.27% (diff: 0.00%)

Merging #314 into master will decrease coverage by 1.70%

@@             master       #314   diff @@
==========================================
  Files            27         28     +1   
  Lines          1441       1470    +29   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            994        989     -5   
- Misses          355        387    +32   
- Partials         92         94     +2   

Powered by Codecov. Last update 158549a...3b74853

Copy link
Contributor

@chungers chungers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "example-code" git@github.com:wfarner/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354164096
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@wfarner wfarner merged commit 227dc68 into docker-archive:master Dec 2, 2016
@wfarner wfarner deleted the example-code branch December 2, 2016 19:03
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Added release buttons to release notes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants