This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Exec schema change and test script updates #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a minor schema change for the config JSON for starting up plugins. Specifically, the configuration and specification of which executor (how the plugin is started -- using
os
or some other mechanism like Docker) is now better associated with the properties required by the executor. The JSON also follows the convention of usingProperties
for arbitrary block of JSON config.scripts/tutorial-test2
) and its config JSON (scripts/tutorial-start-plugins.json
) to reflect the schema change.scripts/tutorial-test2
) to be the target inmake ci
and send kill signals to the process group (of plugins) started by the CLI utilityinfrakit plugin start
. This ensures proper cleanup of the test. Note that we made this possible by setting the plugin processes to be in the same process group as the CLI utility (see the config JSON for entries with propertySamePgID
set totrue
).