Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Jan 15, 2017

This PR moves the example binaries, such as instance-file, instance-terraform and flavor-swarm to a top-level directory instead of pkg/example where they currently are:

  • This makes the examples easier to find.
  • The directory pkg/ is reserved for code in InfraKit that are meant to be imported by other projects. The main packages in the examples/ directory show how this is done.
  • Moved the e2e test / demo script for Docker Swarm flavor to a better home in examples/flavor/swarm
  • Updated docs and references; made sure there are no dead links.

David Chung added 5 commits January 15, 2017 12:11
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
…directory

Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "move-example" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353744704
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov-io
Copy link

codecov-io commented Jan 15, 2017

Current coverage is 64.82% (diff: 100%)

Merging #365 into master will decrease coverage by 0.13%

@@             master       #365   diff @@
==========================================
  Files            47         47          
  Lines          2266       2266          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1472       1469     -3   
- Misses          636        637     +1   
- Partials        158        160     +2   

Powered by Codecov. Last update 89b031a...e583f33

@chungers chungers merged commit def9d15 into docker-archive:master Jan 15, 2017
@chungers chungers deleted the move-example branch January 15, 2017 21:17
@stealthybox stealthybox mentioned this pull request Jun 27, 2017
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants