This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Plugin startup config schema change #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cutors e.g. 'os' and 'docker-run' Signed-off-by: David Chung <david.chung@docker.com>
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
Fix the dependency ordering of CFN templates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the schema of plugin launch config to better support different executors for starting up plugins:
os- usessh -cto start up non-containerized infrakit binaries.docker-runalso usessh -cbut uses Docker as the executor to run the infrakit containersThe change allows a single JSON config to capture different rules by executor. See
scripts/e2e-test-plugins.jsonfor details.In the future other "executors" for starting up plugins will be added -- e.g. tighter Docker integration via API calls or use runc to run the plugins.
TODO - provide full documentation on the config schema and the template in a future release (before reaching v1.0)
Signed-off-by: David Chung david.chung@docker.com