Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Feb 21, 2017

Fix #404

@codecov-io
Copy link

codecov-io commented Feb 21, 2017

Codecov Report

Merging #405 into master will decrease coverage by -0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   62.15%   62.06%   -0.09%     
==========================================
  Files          62       62              
  Lines        3580     3580              
==========================================
- Hits         2225     2222       -3     
- Misses       1106     1107       +1     
- Partials      249      251       +2
Impacted Files Coverage Δ
pkg/plugin/group/scaler.go 91.21% <100%> (+1.4%)
pkg/plugin/group/rollingupdate.go 90.76% <100%> (ø)
pkg/plugin/group/scaled.go 81.48% <100%> (+2.31%)
pkg/plugin/group/quorum.go 86.84% <100%> (ø)
pkg/manager/group_plugin_impl.go 14.89% <ø> (-4.26%)
pkg/manager/manager.go 63.63% <ø> (-2.43%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2e6fb...4406696. Read the comment docs.

Fix docker-archive#404

Signed-off-by: David Gageot <david@gageot.net>
Copy link
Contributor

@chungers chungers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chungers chungers merged commit 1f3e4dc into docker-archive:master Feb 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants