Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Conversation

chungers
Copy link
Contributor

@chungers chungers commented May 5, 2017

This PR

  • Updates the vendor dependency of Sprig to include more functions
  • Add -o option for template engine to write output to file
  • Add vendor dependency to stow for working with different object store backends.

David Chung added 3 commits May 4, 2017 16:39
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "work-0504" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354133360
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov
Copy link

codecov bot commented May 5, 2017

Codecov Report

Merging #523 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   56.69%   56.67%   -0.02%     
==========================================
  Files          57       57              
  Lines        3900     3889      -11     
==========================================
- Hits         2211     2204       -7     
+ Misses       1403     1401       -2     
+ Partials      286      284       -2
Impacted Files Coverage Δ
examples/instance/terraform/plugin.go 62.32% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08eda27...2fab07f. Read the comment docs.

@chungers chungers merged commit 5f389c8 into docker-archive:master May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants