This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Hyperkit plugin fixes #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 5, 2017 11:16
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 56.69% 56.69%
=======================================
Files 57 57
Lines 3900 3900
=======================================
Hits 2211 2211
Misses 1403 1403
Partials 286 286Continue to review full report at Codecov.
|
Signed-off-by: David Chung <david.chung@docker.com>
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
validate template file before proceeding to upgrade
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Oct 1, 2017
validate template file before proceeding to upgrade
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
advertiseflag for hyperkit plugin to use so that on Docker4Mac, the discovery host:port will use the 192.168.65.1 ip that is seen by containers running on Docker4Mac.