Support int and bool types as template CLI vars #543
Conversation
|
@chungers initially I was using the |
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
=======================================
Coverage 56.66% 56.66%
=======================================
Files 57 57
Lines 3937 3937
=======================================
Hits 2231 2231
Misses 1420 1420
Partials 286 286Continue to review full report at Codecov.
|
cmd/infrakit/base/template.go
Outdated
| // that a string like "no" will remain a string. | ||
| if intVal, err := strconv.Atoi(val); err == nil { | ||
| engine.Global(key, intVal) | ||
| } else if val == "true" { |
There was a problem hiding this comment.
I see your point about not using the parseBool function. In this case, there's a strconv.ParseBool that should do the job.. https://golang.org/pkg/strconv/#ParseBool
There was a problem hiding this comment.
Yep, will update to use that so that the parsing is consistent. Thanks for the review!
Instead of assuming that all CLI template `--var` values are String, this adds support to convert the String value to an int or boolean. Closes docker-archive#542 Signed-off-by: Steven Kaufer <kaufer@us.ibm.com>
kaufers
force-pushed
the
template-cli-var-bool
branch
from
7172b45 to
d8efe70
Compare
Added ability to handle Regions with 2 and 3 AZ's in one template.
Added ability to handle Regions with 2 and 3 AZ's in one template.
2 participants
Instead of assuming that all CLI template
--varvalues are String, this adds support to convert the String value to an int or boolean.Closes #542
Signed-off-by: Steven Kaufer kaufer@us.ibm.com