This repository was archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 267
Dynamic and context-driven Infrakit CLI #544
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
- Coverage 56.66% 56.61% -0.05%
==========================================
Files 57 57
Lines 3937 3944 +7
==========================================
+ Hits 2231 2233 +2
- Misses 1420 1425 +5
Partials 286 286
Continue to review full report at Codecov.
|
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
Added new AWS london region
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Oct 1, 2017
Added new AWS london region
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a significant change in the CLI and will be part of the v0.5 release:
instance
,group
,flavor
commands have been made context-sensitive. Specifically, these are no longer subcommands on their own anymore. Instead, the CLI will look at all the plugins known and their interface types and generate appropriate commands (e.g.provision
for an Instance plugin, aprepare
for a flavor plugin). The name of the plugin becomes the subject / command, and the methods/actions (e.g.prepare
,validate
, etc.) become verbs and are subcommands.instance --name foo provision
if the pluginfoo
isn't running. Instead, the command becomesfoo provision
and exists only when a plugin namedfoo
of typeInstance
which supportsprovision
exists.@YujiOshima @ndegory