Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Conversation

chungers
Copy link
Contributor

This PR includes changes to make the command generation more efficient. Specifically there's no need to do two fetches for each cli playbook script - one for determining the backend and one for actual execution.

Signed-off-by: David Chung david.chung@docker.com

David Chung added 2 commits May 17, 2017 11:46
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@codecov
Copy link

codecov bot commented May 17, 2017

Codecov Report

Merging #549 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   56.87%   56.69%   -0.18%     
==========================================
  Files          57       57              
  Lines        3954     3963       +9     
==========================================
- Hits         2249     2247       -2     
- Misses       1419     1430      +11     
  Partials      286      286
Impacted Files Coverage Δ
pkg/template/template.go 66.66% <0%> (-4.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc0579...90a99d1. Read the comment docs.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "work-0517" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353891256
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@chungers chungers merged commit fd983ac into docker-archive:master May 17, 2017
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Fixes docker-archive#549

Signed-off-by: David Gageot <david@gageot.net>
chungers pushed a commit to chungers/infrakit that referenced this pull request Oct 1, 2017
Fixes docker-archive#549

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants