Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Conversation

YujiOshima
Copy link
Contributor

When build per-binary, it doesn't check timestamp.
If there is a binary always make says below even the binary is old.

make build/infrakit-*
make: 'build/infrakit-*' is up to date.

This PR make it check *.go file time stamp.

Signed-off-by: YujiOshima yuji.oshima0x3fd@gmail.com

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@codecov
Copy link

codecov bot commented May 19, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@a2e4ca7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #553   +/-   ##
=========================================
  Coverage          ?   56.69%           
=========================================
  Files             ?       57           
  Lines             ?     3963           
  Branches          ?        0           
=========================================
  Hits              ?     2247           
  Misses            ?     1430           
  Partials          ?      286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e4ca7...e125e96. Read the comment docs.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fixmake" git@github.com:YujiOshima/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842356607768
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@chungers chungers merged commit f552304 into docker-archive:master May 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants