This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[17.06] sort secrets and configs to ensure idempotence #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docker stack deploy` keeps restarting services it doesn't need to (no changes) because the entries' order gets randomized at some previous (de)serialization. Maybe it would be worth looking into this at a higher level and ensure all (de)serialization happens in an ordered collection. This quick fix sorts secrets and configs (in place, mutably) which ensures the same order for each run. Based on moby/moby#30506 Fixes moby/moby#34746 Signed-off-by: Peter Nagy <xificurC@gmail.com> (cherry picked from commit 27e8bdf32bbcc49ff3f8201b6da26aba567aa58e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
|
Closing this PR because the docker-ce 17.06 code-line is EoL. |
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 22, 2018
Merged with https://github.com/seemethere/unir Upstream-commit: 4d3c344a28c3105f9698ed3ae5213e85188eca97 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
May 23, 2019
…drate_when_eating_pretzels [19.03 backport] Fix error handling for bind mount spec parser. Upstream-commit: c56df1abf3ec157c959951dd3faa01aeb87bca16 Component: engine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of docker/cli#509 for 17.06
docker stack deploykeeps restarting services it doesn't need to (no changes)because the entries' order gets randomized at some previous (de)serialization.
Maybe it would be worth looking into this at a higher level and ensure
all (de)serialization happens in an ordered collection.
This quick fix sorts secrets and configs (in place, mutably) which ensures the
same order for each run.
Based on
moby/moby#30506
Fixes
moby/moby#34746
(cherry picked from commit 27e8bdf32bbcc49ff3f8201b6da26aba567aa58e)