This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Builder: fix "COPY --from" to non-existing directory on Windows [ENGCORE-935] #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of:
Run-IntegrationTests()
: set working directory for test suiteCOPY --from
to non-existing directory on Windowsfixes docker/for-win#4349
built on top of moby#39698
This fixes a regression introduced in 6d87f19 (moby#38599),
causing
COPY --from
to fail if the target directory does not exist:Would produce an error:
The cause for this was that Go's
os.MkdirAll()
does not support/detect volume GUID paths(
\\?\Volume{dae8d3ac-b9a1-11e9-88eb-e8554b2ba1db}\hello\another}
), and as a resultattempted to create the volume as a directory (
\\?
), causing it to fail.This patch replaces
os.MkdirAll()
with our ownsystem.MkdirAll()
function, whichis capable of detecting GUID volumes.
- How to verify it
To verify (on Linux; don't know the equivalent on Windows, LOL):
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)