This repository was archived by the owner on Jan 20, 2020. It is now read-only.
Reconnection feature #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have merged it into staging branch. Will release new version in 1 week or 2. Thank you :) |
|
@tifayuki Nice one, thank you! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of cloud providers are terminating long running connections (eg for MS Azure it's 4min default). So in this case a socket (which is created by the main Session object) may be closed and client will get this error https://www.dropbox.com/s/t2obll61wdzrxdq/Screen%20Shot%202017-01-03%20at%2003.23.57.png?dl=0
So, this issue may be prevented if the connection is reopened in some interval.
Looking forward to merging this PR, thank you.