[fix] 색상 변수 생성 및 적용 #157
Merged
[fix] 색상 변수 생성 및 적용 #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Tailwind CSS color variables and updates components to use them, replacing hardcoded hex values.
- Defined reusable color variables in
tailwind.config.js. - Updated header, footer, and button components to use
bg-docker-primary,hover:bg-docker-hover, etc. - Added a hidden
<div>inindex.htmlto force Tailwind to include the new utility classes.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/content_style.css | Added background: #f8f9fa; to <pre> blocks |
| src/scripts/components/header-component.ts | Replaced bg-[#086dd7] with bg-docker-primary (plus inline style) |
| src/scripts/components/footer-component.ts | Replaced bg-[#086dd7] with bg-docker-primary |
| src/scripts/components/button-component.ts | Replaced hex classes with bg-docker-primary and hover:bg-docker-hover |
| index.html | Added hidden <div> to ensure Tailwind picks up new utility classes |
Comments suppressed due to low confidence (1)
src/scripts/components/button-component.ts:24
- The class
text-white!is not a valid Tailwind utility; if you intended to use!important, Tailwind uses a!prefix (e.g.,!text-white). Please correct the class name.
<a href="${href}" class="cursor-pointer py-2 px-4 rounded bg-docker-primary hover:bg-docker-hover text-white!">
| #content pre { | ||
| padding: 0.5rem; | ||
| border: 2px solid #e1e2e6; | ||
| background: #f8f9fa; |
There was a problem hiding this comment.
[nitpick] Consider using Tailwind’s utility classes or @apply (e.g., @apply bg-background-light;) instead of hardcoding a hex value, to keep styling consistent with the rest of the project.
Suggested change
| background: #f8f9fa; | |
| @apply bg-gray-100; |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tailwind.config.js에 색상 변수 정의bg-docker-primary와 같이{적용 위치(배경, 텍스트 등)}-{적용하고자 하는 색}의 형식으로 사용 가능close #146