Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZNC documentation in content.md for docker compose #2441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robmarkoski
Copy link

Added an example Docker Compose for normal operation as well as first run configuration.

Added a Troubleshoot Section to include potential permission issues.

Additional changes

  • Corrected headings levels.

Added an example Docker Compose for normal operation as well as first run configuration.

Added a Troubleshoot Section to include potential permission issues.

Additional changes

- Corrected headings levels.
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @DarthGandalf (znc image maintainer) for review as well 🙇

Comment on lines +29 to +44
## Install using [`docker-compose`](https://github.com/docker/compose)

Example `docker-compose.yml` for `znc`:

```yaml
znc:
image: znc:latest
container_name: znc
volumes:
- /your/local/znc-data:/znc-data
ports:
- 12345:12345
restart: unless-stopped
```

Then run with `docker-compose up -d`, and when initialized go to `http://dockerhost:12345`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should probably follow our standard stack.yml pattern elsewhere in the documentation (and should likely use a local Docker volume instead of a bind-mount).


```yaml
znc:
image: znc:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this one won't be able to follow that pattern, it can take advantage of our templating (so that it's correct on the per-architecture image pages too):

Suggested change
image: znc:latest
image: %%IMAGE%%


```yaml
znc:
image: znc:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: znc:latest
image: %%IMAGE%%

(same as above)

@@ -6,7 +6,7 @@ ZNC is an IRC network bouncer (BNC). It can detach the client from the actual IR

[ZNC Wiki](http://znc.in/)

# How to use this image
## How to use this image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was wrong with header?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just being pedantic. Only single top line heading


### Running ZNC for first time (No config)

If this is your first time running ZNC (and have no configuration file), use the following `docker-compose.yml`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one-off run, I don't see how docker-compose is any better than the docker run command from above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats true. Maybe should just update it to explain the process first? i.e. explain that its required before you setup the docker-compose or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants