Add jsyaml to parse mongod.conf (especially to remove problematic sections for our initdb logic) #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions for our initdb logic)
yosifkit
approved these changes
Dec 20, 2017
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 21, 2017
- `mongo`: lots of initdb changes (docker-library/mongo#227, docker-library/mongo#226, docker-library/mongo#225) - `python`: 3.6.4 - `rabbitmq`: fix boolean values (docker-library/rabbitmq#227)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the functionality added in #145 (improved in #183), and the request for documentation in #189).
More specifically, this adjusts our
docker-entrypoint.shto use a YAML parser to convert a supplied YAMLmongodconfiguration file into JSON so that we can parse/munge it withjqsuch that we can remove problematic configuration options for our "initdb" logic (such as SSL or authorization configuration).This removes our longest-standing
TODOitem with this functionality, and the primary reason for it still being considered experimental (and thus not being documented, as noted in #189).Closes #148
Closes #172
Closes #176