Add Java 6 and 8, pin 7 to a more specific version number, and add "curl" and "wget" for downloading dependencies in dependent Dockerfiles #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
yosifkit
added a commit
that referenced
this pull request
Jul 18, 2014
Add Java 6 and 8, pin 7 to a more specific version number, and add "curl" and "wget" for downloading dependencies in dependent Dockerfiles
|
I think What is holding up seeing tags 6,7,8 in the registry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
I think we should possibly consider more tags on
buildpack-depsso we could use it here too (ie,buildpack-deps:debian-wheezy, etc might be appropriate), but I don't know how common it is for Java things to depend on C code and/or C headers (I would guess that it's not that common).