-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine 3.17 variant #1348
Add Alpine 3.17 variant #1348
Conversation
Seems like this breaks with older PHP versions due to the update to OpenSSL 3.0 as default version. I will try to look into this later. |
9d554f3
to
6a98330
Compare
Hmmm this seems to be more tricky than I anticipated. The I figured there are at least two ways to solve this problem:
I'll wait for a maintainer to come around and discuss these and possible other solutions. Update 25/11: I rebased this branch onto #1349 here, to make things slightly easier. It would still require some fix for the 8.0 variant. |
Thank you for starting the work here and finding the bodies! 😄 IMO we should "solve" this by only supporting Alpine 3.17+ for versions which support OpenSSL 3+ (no strong opinion either way from me on whether we drop 3.15 from all or just from those that get 3.17, but definitely no more than two Alpine versions for any given PHP version). 🚀 I'm happy to work on the necessary conditionals for doing so if that isn't something you want to tackle. 👍 |
6a98330
to
cd2349d
Compare
I've gone with dropping Alpine 3.15 altogether, leaving 8.0 with a single supported Alpine variant. The git diff is a bit weird with file moves (e.g. |
Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
Thanks! |
Changes: - docker-library/php@d461611: Add Alpine 3.17 variant (docker-library/php#1348) - docker-library/php@2a7223d: Merge pull request docker-library/php#1349 from jnoordsij/remove-7.4
This PR provides the latest Alpine version (3.17, see https://alpinelinux.org/posts/Alpine-3.17.0-released.html) and removes the oldest one (3.15).
Alpine 3.17 variant is only added for PHP versions with OpenSSL support (i.e. PHP >= 8.1), see also comment below.
Based on #1298.