Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP 7.4 #1349

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Remove PHP 7.4 #1349

merged 2 commits into from
Nov 28, 2022

Conversation

jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Nov 25, 2022

Based on #1270.

PHP 7.4 will reach EOL on November 28 2022 (see https://www.php.net/supported-versions.php).
This PR removes the 7.4-based images and aliases.

It is probably unwanted to merge this before November 28th, hence the draft state.
This also might make fixing #1348 a bit easier.

@jnoordsij jnoordsij marked this pull request as ready for review November 28, 2022 09:02
@tianon
Copy link
Member

tianon commented Nov 28, 2022

As much as I'd love to be aggressive here, we've been bit by doing so in the past (a last-minute "final" release of an EOL series, especially for security fixes that happened to land near the EOL date), so I'd like to come back to this in maybe a week or two (or wait for one of the release managers for 7.4 to comment here or elsewhere, which isn't _un_heard of in this repository, but I wouldn't want to be a bother to them by pinging them explicitly 😅).

@tianon
Copy link
Member

tianon commented Nov 28, 2022

Scratch that, https://twitter.com/official_php/status/1597203297537957888 is pretty darn official. 👍 😄

@tianon
Copy link
Member

tianon commented Nov 28, 2022

All the version_id removals!!!! 😍

Thank you for being so thorough 🙇

@tianon tianon merged commit 2a7223d into docker-library:master Nov 28, 2022
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 29, 2022
Changes:

- docker-library/php@2a7223d: Merge pull request docker-library/php#1349 from jnoordsij/remove-7.4
@jnoordsij jnoordsij deleted the remove-7.4 branch November 29, 2022 09:06
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 30, 2022
Changes:

- docker-library/php@d461611: Add Alpine 3.17 variant (docker-library/php#1348)
- docker-library/php@2a7223d: Merge pull request docker-library/php#1349 from jnoordsij/remove-7.4
@jnoordsij jnoordsij mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants