Add liburing support to 18+ #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we update the comment while we are here? 🙈 |
yosifkit
reviewed
Sep 30, 2025
| zstd-dev \ | ||
| {{ ) else "" end -}} | ||
| {{ if .major >= 18 then ( -}} | ||
| # https://www.postgresql.org/docs/18/install-make.html#CONFIGURE-OPTION-WITH-LIBURING |
There was a problem hiding this comment.
We don't just add configure flags because they exist. Can we also link the Debian change for justification? https://salsa.debian.org/postgresql/postgresql-common/-/commit/89c384273f4c4092483598c292b1b1b188816cce
There was a problem hiding this comment.
pfffft
(yes, good point, will update)
This is a bit complicated to use in Docker (because `io_uring` has a long and storied security story), but it is a new feature of 18+ that we should probably explicitly support for users who want to jump through the hoops to use it despite the security risk. Additionally, this re-alphabetizes our `--with-xxx` flags.
yosifkit
approved these changes
Sep 30, 2025
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Sep 30, 2025
Changes: - docker-library/postgres@06388fc: Merge pull request docker-library/postgres#1366 from infosiftr/liburing - docker-library/postgres@2c75134: Add liburing support to 18+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit complicated to use in Docker (because
io_uringhas a long and storied security story), but it is a new feature of 18+ that we should probably explicitly support for users who want to jump through the hoops to use it despite the security risk.Additionally, this re-alphabetizes our
--with-xxxflags.(with special thanks to @ImreSamu for being so excellent all the time)