Remove deprecated -e/--email flag from docker login #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `docker login -e` / `docker login --email` option was deprecated in Docker 1.11 (https://github.com/moby/moby/releases/tag/v1.11.0) through aee260d (April 2016), and when used has been outputing a deprecation warning since; Flag --email has been deprecated, will be removed in 17.06. Originally this option was scheduled to be removed in docker 1.13, but extended to docker 17.06 due to a change in our deprecation policy. Given that only docker 1.10 and older use this flag (which is EOL, including for CS versions, as of February 2017), will now be removed. With this patch, `docker login` will now produce an Error if the flag is used. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
23 tasks
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 44.96% 44.96%
=======================================
Files 169 169
Lines 11378 11378
=======================================
Hits 5116 5116
Misses 5970 5970
Partials 292 292 |
|
All :green: |
40 tasks
mooyoul
added a commit
to balmbees/opsworks_custom_cookbooks
that referenced
this pull request
Jun 29, 2017
matiasgarciaisaia
added a commit
to instedd/active-monitoring
that referenced
this pull request
Dec 13, 2017
matiasgarciaisaia
added a commit
to instedd/cruzroja-registro
that referenced
this pull request
Jun 28, 2018
It has been removed a while ago See docker/cli#143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docker login -e/docker login --emailoption was deprecated inDocker 1.11 (https://github.com/moby/moby/releases/tag/v1.11.0) through
aee260d (April 2016), and when used has
been outputing a deprecation warning since;
Originally this option was scheduled to be removed in docker 1.13, but
extended to docker 17.06 due to a change in our deprecation policy.
Given that only docker 1.10 and older use this flag (which is EOL, including
for CS versions, as of February 2017), will now be removed.
With this patch,
docker loginwill now produce an Error if the flagis used.
closes moby/moby#23390