New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated -e/--email flag from docker login #143

Merged
merged 1 commit into from Jun 2, 2017

Conversation

Projects
None yet
5 participants
@thaJeztah
Member

thaJeztah commented Jun 1, 2017

The docker login -e / docker login --email option was deprecated in
Docker 1.11 (https://github.com/moby/moby/releases/tag/v1.11.0) through
aee260d (April 2016), and when used has
been outputing a deprecation warning since;

Flag --email has been deprecated, will be removed in 17.06.

Originally this option was scheduled to be removed in docker 1.13, but
extended to docker 17.06 due to a change in our deprecation policy.

Given that only docker 1.10 and older use this flag (which is EOL, including
for CS versions, as of February 2017), will now be removed.

With this patch, docker login will now produce an Error if the flag
is used.

closes moby/moby#23390

Remove deprecated -e/--email flag from docker login
The `docker login -e` / `docker login --email` option was deprecated in
Docker 1.11 (https://github.com/moby/moby/releases/tag/v1.11.0) through
aee260d (April 2016), and when used has
been outputing a deprecation warning since;

    Flag --email has been deprecated, will be removed in 17.06.

Originally this option was scheduled to be removed in docker 1.13, but
extended to docker 17.06 due to a change in our deprecation policy.

Given that only docker 1.10 and older use this flag (which is EOL, including
for CS versions, as of February 2017), will now be removed.

With this patch, `docker login` will now produce an Error if the flag
is used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 1, 2017

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   44.96%   44.96%           
=======================================
  Files         169      169           
  Lines       11378    11378           
=======================================
  Hits         5116     5116           
  Misses       5970     5970           
  Partials      292      292

codecov-io commented Jun 1, 2017

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   44.96%   44.96%           
=======================================
  Files         169      169           
  Lines       11378    11378           
=======================================
  Hits         5116     5116           
  Misses       5970     5970           
  Partials      292      292
@dnephin

dnephin approved these changes Jun 1, 2017

LGTM

@vdemeester

LGTM 🐸

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jun 2, 2017

Member

All :green:

Member

thaJeztah commented Jun 2, 2017

All :green:

@thaJeztah thaJeztah merged commit a0066a1 into docker:master Jun 2, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing efaadcf...8b383d2
Details
codecov/project 44.96% remains the same compared to efaadcf
Details
dco-signed All commits are signed

@thaJeztah thaJeztah referenced this pull request Jun 7, 2017

Closed

17.06.0 RC3 tracker #8

40 of 40 tasks complete

@thaJeztah thaJeztah deleted the thaJeztah:remove-email-flag branch Jun 9, 2017

mooyoul added a commit to balmbees/opsworks_custom_cookbooks that referenced this pull request Jun 29, 2017

matiasgarciaisaia added a commit to instedd/active-monitoring that referenced this pull request Dec 13, 2017

matiasgarciaisaia added a commit to instedd/cruzroja-registro that referenced this pull request Jun 28, 2018

Drop docker login `-e` flag
It has been removed a while ago

See docker/cli#143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment