New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: Show success message when finished counting down #260

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
5 participants
@aaronlehmann
Collaborator

aaronlehmann commented Jun 27, 2017

This avoids leaving a message on the terminal saying there's 1 second remaining. See #237 (comment).

Open to suggestions on the wording.

cc @thaJeztah

progress: Show success message when finished counting down
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jun 28, 2017

Member

Verified this is working as expected;

$ docker service create --detach=false nginx:alpine
u7rp6ecohz0f3nvygihje5brr
overall progress: 1 out of 1 tasks
1/1: running   [==================================================>]
verify: Service converged
Member

thaJeztah commented Jun 28, 2017

Verified this is working as expected;

$ docker service create --detach=false nginx:alpine
u7rp6ecohz0f3nvygihje5brr
overall progress: 1 out of 1 tasks
1/1: running   [==================================================>]
verify: Service converged
@thaJeztah

LGTM

ping @vdemeester PTAL

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 28, 2017

Codecov Report

Merging #260 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   46.85%   46.83%   -0.02%     
==========================================
  Files         172      172              
  Lines       11692    11692              
==========================================
- Hits         5478     5476       -2     
- Misses       5902     5904       +2     
  Partials      312      312

codecov-io commented Jun 28, 2017

Codecov Report

Merging #260 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   46.85%   46.83%   -0.02%     
==========================================
  Files         172      172              
  Lines       11692    11692              
==========================================
- Hits         5478     5476       -2     
- Misses       5902     5904       +2     
  Partials      312      312
@vdemeester

LGTM 🦁

@vdemeester vdemeester merged commit 92a2a1d into docker:master Jun 28, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 2eac0bb...82e0690
Details
codecov/project 46.83% (-0.02%) compared to 2eac0bb
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jun 28, 2017

@aaronlehmann aaronlehmann deleted the aaronlehmann:verify-message branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment