New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password stdin #271

Merged
merged 1 commit into from Jul 13, 2017

Conversation

@tych0
Contributor

tych0 commented Jun 29, 2017

Add a --password-stdin argument to the login command, and update the warning message from #270 to tell people about it.

Show outdated Hide outdated cli/command/registry/login.go Outdated
Show outdated Hide outdated cli/command/registry/login.go Outdated
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 3, 2017

Codecov Report

Merging #271 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files         186      186           
  Lines       12416    12416           
=======================================
  Hits         6045     6045           
  Misses       5996     5996           
  Partials      375      375

codecov-io commented Jul 3, 2017

Codecov Report

Merging #271 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files         186      186           
  Lines       12416    12416           
=======================================
  Hits         6045     6045           
  Misses       5996     5996           
  Partials      375      375
Show outdated Hide outdated cli/command/registry/login.go Outdated
Show outdated Hide outdated cli/command/registry/login.go Outdated
@tych0

This comment has been minimized.

Show comment
Hide comment
@tych0

tych0 Jul 11, 2017

Contributor

Ping. Any movement on this?

Contributor

tych0 commented Jul 11, 2017

Ping. Any movement on this?

@n4ss

This comment has been minimized.

Show comment
Hide comment
@n4ss

n4ss Jul 11, 2017

Contributor

LGTM!

Contributor

n4ss commented Jul 11, 2017

LGTM!

@n4ss

This comment has been minimized.

Show comment
Hide comment
@n4ss

n4ss Jul 11, 2017

Contributor
Contributor

n4ss commented Jul 11, 2017

@vdemeester

Design LGTM 👼

login: add a --password-stdin argument
This:

* conflicts with --password (naturally)
* conflicts with the absence of --username (both can't be grabbed by the
  stdin)
* strips a trailing newline off the password if it exists

Signed-off-by: Tycho Andersen <tycho@tycho.ws>
@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Jul 11, 2017

Collaborator

LGTM

Collaborator

aaronlehmann commented Jul 11, 2017

LGTM

@thaJeztah

LGTM --password-stdin is a bit verbose, but don't have a better solution (perhaps a -i shortcut)?

We probably want this in 17.07, so I'm ok merging as-is, but we also need;

@tych0

This comment has been minimized.

Show comment
Hide comment
@tych0

tych0 Jul 13, 2017

Contributor

Sure, I can work up docs patches, feel free to merge.

Contributor

tych0 commented Jul 13, 2017

Sure, I can work up docs patches, feel free to merge.

@thaJeztah thaJeztah merged commit ae38f20 into docker:master Jul 13, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6908e58...7d18477
Details
codecov/project 48.68% remains the same compared to 6908e58
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment