New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack output stream #298

Merged
merged 2 commits into from Jul 10, 2017

Conversation

Projects
None yet
5 participants
@dnephin
Collaborator

dnephin commented Jul 5, 2017

Fixes moby/moby#33954

"Nothing found in stack" should go to stderr

Also cleaned up some duplication in task format selection

dnephin added some commits Jul 5, 2017

Fix stream for 'nothing found in stack' message
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Remove duplication in task formatting.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 5, 2017

Codecov Report

Merging #298 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   48.93%   48.92%   -0.01%     
==========================================
  Files         177      177              
  Lines       11846    11840       -6     
==========================================
- Hits         5797     5793       -4     
  Misses       5687     5687              
+ Partials      362      360       -2

codecov-io commented Jul 5, 2017

Codecov Report

Merging #298 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   48.93%   48.92%   -0.01%     
==========================================
  Files         177      177              
  Lines       11846    11840       -6     
==========================================
- Hits         5797     5793       -4     
  Misses       5687     5687              
+ Partials      362      360       -2
@thaJeztah

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah
Member

thaJeztah commented Jul 10, 2017

ping @vdemeester PTAL

@vdemeester

LGTM 🐸

@vdemeester vdemeester merged commit af6c089 into docker:master Jul 10, 2017

7 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 50% of diff hit (target 50%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +1.06% compared to 30933b5
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment