`client.pull(stream=True)` doesn't split stream lines correctly?

[joshuaconner]

This is on Ubuntu 13.10, with Docker 0.10.0:

Python 2.7.5+ (default, Sep 19 2013, 13:48:49)
[GCC 4.8.1] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import docker.client
>>> client = docker.Client()
>>> stream = client.pull('busybox', stream=True)
>>> chunks = [chunk for chunk in stream]
>>> len(chunks)
2
>>> chunks[0]
'{"status":"Pulling repository busybox"}'
>>> len(chunks[1])
22721

Basically chunks[0] is one line of the stream, and chunks[1] is every other line of the stream, concatenated. (I can take a look at making a PR for this tomorrow, if you'd like.)

[mpetazzoni]

Thanks for reporting this. I don't think we've validated docker-py with Docker 0.10 yet. Correctly returning the streamed lines has been a constant challenge because Docker changed the outputted stream format, and it's wasn't consistent across all endpoints. Hopefully 0.10 brings some sanity to this.

[blalor]

Along these lines, pulling a non-existent repository doesn't result in an error. It should throw an exception, but in my case I'm just getting

{"status":"Pulling repository apps/skydock-nginx"}
{"errorDetail":{"message":"HTTP code: 404"},"error":"HTTP code: 404"}

I don't think it warrants its own issue, but it is a problem I've run into.