Client.build parameters do not match docker build parameters

[alexliew]

Client.build has a default rm=False parameter whereas it is --rm=true for docker build.
Also, Client.build does not have a force-rm option. I don't use it myself, but I'm not sure if it got left out.

[mpapierski]

👍
I just noticed the same issue

[twllight]

I just noticed as well when using the tag parameter within Client.build that it will default to for Repository and Tag, unless you provide a colon after your tag (ie: bigtest/funtimes will turn into but bigtest/funtimes:latest will showup correctly. Just something I found.

[ssanderson]

This just bit me rather hard: I spent about 4 hours trying to figure out how I was creating phantom exited containers before I finally realized that rm was being sent as False to /build. I ended up filing #401 before realizing what was happening.

[shin-]

Hmm, looks like we've lost information on default values with the new docs. We'll need to fix that.

For the record, default in the Docker API/CLI used to be rm=False, so it was implemented as such in docker-py. It was then changed on the Docker side, but I'm wary of breaking this for all the people relying on the current default, considering there doesn't seem to be a compelling reason to do it other than the unfortunate mismatch.

[gtaylor]

Sent a pull request just for the --rm=true/rm=False default mis-match. I would have never noticed that difference until something unexpected started manifesting.

It looks like forcerm now exists and is documented, addressing the other issue mentioned.