Upgrade to requests 2.0.1 (or newer)

[aboe76]

Could docker-py be updated to be compatible with python-requests 2.0.1?

I'm getting this error: AttributeError: 'UnixHTTPConnectionPool' object has no attribute 'strip'

traceback:

File "/usr/lib/python2.7/site-packages/docker/client.py", line 314, in info
            return self._result(self.get(self._url("/info")), True)
          File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 373, in get
            return self.request('GET', url, **kwargs)
          File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 361, in request
            resp = self.send(prep, **send_kwargs)
          File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 464, in send
            r = adapter.send(request, **kwargs)
          File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 296, in send
            conn = self.get_connection(request.url, proxies)
          File "/usr/lib/python2.7/site-packages/docker/unixconn/unixconn.py", line 65, in get_connection
            return UnixHTTPConnectionPool(self.base_url, socket_path)
          File "/usr/lib/python2.7/site-packages/docker/unixconn/unixconn.py", line 53, in __init__
            super(UnixHTTPConnectionPool, self).__init__(self, 'localhost')
          File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 144, in __init__
            ConnectionPool.__init__(self, host, port)
          File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 73, in __init__
            host = host.strip('[]')
        AttributeError: 'UnixHTTPConnectionPool' object has no attribute 'strip'

[shin-]

It's honestly not on my list of priorities right now. I think requests 1.2.3 works fine. Is there a reason we would want to upgrade?

[aboe76]

Just too make distribution easier, if distros ship the new python package they don't have to keep the old one,

I can understand a reject if the update isn't backward compatible.

[aboe76]

Another security incentive:

2.0.1 (2013-10-24)
Updated included CA Bundle with new mistrusts and automated process for the future

[shin-]

I think it's going to be non-trivial to upgrade to another major version of requests, especially because we would have to adapt the custom adapter classes and all that jazz that are used to support the unix:// protocol (see docker/unixconn/unixconn.py).

Let's say it's low priority -- if someone wants to tackle it I'm not against it, but I'd rather focus on other issues.

[shin-]

Fixed by #151