Certificate error in docker ci for test-docker-py

[keloyang]

https://jenkins.dockerproject.org/job/Docker-PRs/24848/console for detail.
in docker-py, when checkout to the commit of 387db11,the error appears,if I remove the commit ,we will not have the error.

==================================== ERRORS ====================================
_________________ ERROR at setup of InformationTest.test_info __________________
/docker-py/tests/integration/conftest.py:17: in setup_test_session
    c = docker_client()
/docker-py/tests/helpers.py:61: in docker_client
    return docker.Client(**docker_client_kwargs(**kwargs))
/docker-py/tests/helpers.py:65: in docker_client_kwargs
    client_kwargs = docker.utils.kwargs_from_env(assert_hostname=False)
/docker-py/docker/utils/utils.py:486: in kwargs_from_env
    assert_fingerprint=tls_verify)
/docker-py/docker/tls.py:47: in __init__
    'Path to a certificate and key files must be provided'
E   TLSParameterError: Path to a certificate and key files must be provided through the client_config 
param. TLS configurations should map the Docker CLI client configurations. 
See https://docs.docker.com/engine/articles/https/ for API details.
________________ ERROR at setup of InformationTest.test_search _________________
...

[colin-nolan]

I am also encountering this problem. It occurs when DOCKER_CERT_PATH and DOCKER_TLS_VERIFY are both set to empty string (i.e. the rather odd way of stating that the the connection to the Docker daemon should not be secure). This environment setup is not tested here:

docker-py/tests/unit/utils_test.py

Line 159 in 387db11

class KwargsFromEnvTest(base.BaseTestCase):

.

The issue is with the kwargs_from_env method in docker/utils/util.py. In release 1.7.0, a TLSConfig instance was only constructed if tls_verify and cert_path were True:
https://github.com/docker/docker-py/blob/release-1.7.0/docker/utils/utils.py#L460

This is no longer the case in release 1.7.1 onwards:
https://github.com/docker/docker-py/blob/1.7.1-release/docker/utils/utils.py#L485

[shin-]

Thank you for the report. Have you tried it with the fix 9ba0ddf ? We released 1.7.2 to try and address those TLS issues, but it's possible we might have missed a case.

[shin-]

Do you folks mind trying #988 (commit SHA: ad480ff) and see if it solves the problems you're experiencing?

[keloyang]

I have a try and #988 is ok.